[v18.x backport] lib: enable global CustomEvent by default#52270
Closed
himself65 wants to merge 1 commit intonodejs:v18.x-stagingfrom
Closed
[v18.x backport] lib: enable global CustomEvent by default#52270himself65 wants to merge 1 commit intonodejs:v18.x-stagingfrom
himself65 wants to merge 1 commit intonodejs:v18.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
himself65
force-pushed
the
himself65/20240529-pick
branch
from
bc15550 to
6cf4503
Compare
Refs: nodejs#43885 Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: nodejs#44860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
himself65
force-pushed
the
himself65/20240529-pick
branch
from
6cf4503 to
782a6e4
Compare
Member
#43885 is already in Node.js 18: node/doc/changelogs/CHANGELOG_V18.md Line 3535 in 7c02486 This instead appears to be backporting #44860 and that is semver-major. |
mcollina
requested changes
Mar 30, 2024
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I'm sorry but adding new globals is semver-major, and we can't backport this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #43885
Fixes: #52269